Re: [coreboot] [PATCH] version 2, Generate multiboot tables after and from coreboot tables

[Myles Watson]

On Tue, Aug 31, 2010 at 9:27 AM, Juhana Helovuo  wrote:
> On Mon, 2010-08-30 at 21:46 +0200, Patrick Georgi wrote:
> > Am 30.08.2010 20:54, schrieb Juhana Helovuo:
> > > Hello,
> > >
> > > The attached patch adds all the memory memory ranges in the coreboot
> > > tables also to the multiboot tables. It is useful e.g. when booting
> > > Linux with Grub2 payload, since then Linux gets the Coreboot memory map
> > > via multiboot tables.
> > >
> > > This patch causes multiboot table to be located in memory before
> > > coreboot tables, but it seemed to cause no harm for me.
> > >
> > > Signed-off-by: Juhana Helovuo
> >
> > I like the change, except for the #if 0 section. Could that code be
> > removed entirely, or is there a reason for keeping it?
> > Also, what's up with reserved_mem_count? Does that serve any purpose
> > other than dumping the multiboot tables?

I don't think we should keep the name reserved_mem_count if we
increment it for all regions.
> Ok, here is attached 2nd version of the patch. It is the simpler
> alternative (#2) outlined in my previous mail.

I simplified a little more.  It would be even simpler if we dumped the
table while it was being built.

Signed-off-by: Myles Watson

Thanks,
Myles