Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1497908: (UNINIT) /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1219 in edp_ctrl_calc_tu() /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1218 in edp_ctrl_calc_tu() /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1221 in edp_ctrl_calc_tu() /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1220 in edp_ctrl_calc_tu() /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1163 in edp_ctrl_calc_tu()
________________________________________________________________________________________________________ *** CID 1497908: (UNINIT) /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1219 in edp_ctrl_calc_tu() 1213 tu.delay_start_time_fp = (tu.delay_start_link * f) / tu.lclk; 1214 1215 /* OUTPUTS */ 1216 tu_table->valid_boundary_link = tu.valid_boundary_link; 1217 tu_table->delay_start_link = tu.delay_start_link; 1218 tu_table->boundary_moderation_en = tu.boundary_moderation_en;
CID 1497908: (UNINIT) Using uninitialized value "tu.valid_lower_boundary_link".
1219 tu_table->valid_lower_boundary_link = tu.valid_lower_boundary_link; 1220 tu_table->upper_boundary_count = tu.upper_boundary_count; 1221 tu_table->lower_boundary_count = tu.lower_boundary_count; 1222 tu_table->tu_size_minus1 = tu.tu_size_minus1; 1223 1224 printk(BIOS_INFO, "TU: valid_boundary_link: %d\n", /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1218 in edp_ctrl_calc_tu() 1212 1213 tu.delay_start_time_fp = (tu.delay_start_link * f) / tu.lclk; 1214 1215 /* OUTPUTS */ 1216 tu_table->valid_boundary_link = tu.valid_boundary_link; 1217 tu_table->delay_start_link = tu.delay_start_link;
CID 1497908: (UNINIT) Using uninitialized value "tu.boundary_moderation_en".
1218 tu_table->boundary_moderation_en = tu.boundary_moderation_en; 1219 tu_table->valid_lower_boundary_link = tu.valid_lower_boundary_link; 1220 tu_table->upper_boundary_count = tu.upper_boundary_count; 1221 tu_table->lower_boundary_count = tu.lower_boundary_count; 1222 tu_table->tu_size_minus1 = tu.tu_size_minus1; 1223 /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1221 in edp_ctrl_calc_tu() 1215 /* OUTPUTS */ 1216 tu_table->valid_boundary_link = tu.valid_boundary_link; 1217 tu_table->delay_start_link = tu.delay_start_link; 1218 tu_table->boundary_moderation_en = tu.boundary_moderation_en; 1219 tu_table->valid_lower_boundary_link = tu.valid_lower_boundary_link; 1220 tu_table->upper_boundary_count = tu.upper_boundary_count;
CID 1497908: (UNINIT) Using uninitialized value "tu.lower_boundary_count".
1221 tu_table->lower_boundary_count = tu.lower_boundary_count; 1222 tu_table->tu_size_minus1 = tu.tu_size_minus1; 1223 1224 printk(BIOS_INFO, "TU: valid_boundary_link: %d\n", 1225 tu_table->valid_boundary_link); 1226 printk(BIOS_INFO, "TU: delay_start_link: %d\n", /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1220 in edp_ctrl_calc_tu() 1214 1215 /* OUTPUTS */ 1216 tu_table->valid_boundary_link = tu.valid_boundary_link; 1217 tu_table->delay_start_link = tu.delay_start_link; 1218 tu_table->boundary_moderation_en = tu.boundary_moderation_en; 1219 tu_table->valid_lower_boundary_link = tu.valid_lower_boundary_link;
CID 1497908: (UNINIT) Using uninitialized value "tu.upper_boundary_count".
1220 tu_table->upper_boundary_count = tu.upper_boundary_count; 1221 tu_table->lower_boundary_count = tu.lower_boundary_count; 1222 tu_table->tu_size_minus1 = tu.tu_size_minus1; 1223 1224 printk(BIOS_INFO, "TU: valid_boundary_link: %d\n", 1225 tu_table->valid_boundary_link); /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1163 in edp_ctrl_calc_tu() 1157 tu.delay_start_link_extra_pclk = EXTRA_PIXCLK_CYCLE_DELAY; 1158 tu.diff_abs_fp = tu.resulting_valid_fp - tu.ratio_by_tu_fp; 1159 if (tu.diff_abs_fp < 0) 1160 tu.diff_abs_fp = tu.diff_abs_fp * -1; 1161 1162 tu.boundary_mod_lower_err = 0;
CID 1497908: (UNINIT) Using uninitialized value "tu.min_hblank_violated".
1163 if ((tu.diff_abs_fp != 0 && 1164 ((tu.diff_abs_fp > BRUTE_FORCE_THRESHOLD_fp) || 1165 (tu.even_distribution_legacy == 0) || 1166 (DP_BRUTE_FORCE == 1))) || 1167 (tu.min_hblank_violated == 1)) { 1168 do { /src/soc/qualcomm/sc7280/display/edp_ctrl.c: 1181 in edp_ctrl_calc_tu() 1175 for (tu.i_upper_boundary_count = 1; 1176 tu.i_upper_boundary_count <= 15; 1177 tu.i_upper_boundary_count++) { 1178 for (tu.i_lower_boundary_count = 1; 1179 tu.i_lower_boundary_count <= 15; 1180 tu.i_lower_boundary_count++) {
CID 1497908: (UNINIT) Using uninitialized value "tu.min_hblank_violated" when calling "tu_valid_boundary_calc".
1181 tu_valid_boundary_calc(&tu); 1182 } 1183 } 1184 } 1185 tu.delay_start_link_extra_pclk--; 1186 } while (tu.boundary_moderation_en != true &&
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...