On Thu, May 29, 2008 at 11:58:10AM +0300, Andriy Gapon wrote:
This board can not be uniquely identified by PCI devices, all of them are part of 440BX/PIIX4E chipset.
"artecgroup", "dbe62", "Artec Group DBE62", board_artecgroup_dbe6x},
{0x8086, 0x27b8, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, "kontron", "986lcd-m", "Kontron 986LCD-M", board_kontron_986lcd_m},
- {0x8086, 0x7113, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
{0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL} /* Keep this */"delta", "mp2-bx-x", "Delta MP2-BX-X", board_mp2_bx_x},
};
I see a lot of 0's in the pci-id list, same for the kontron board.
Surely at least one other set of main device ids can be put in there. Due to the lack of subsystem ids this will not give you unique identification, but this will provide an additional safeguard.
For the recent kontron board, though, nothing less than a full set seems acceptable. Unless kontron, as an embedded vendor, couldn't be bothered with card ids as usual.
Luc Verhaegen. SUSE/Novell X Driver Developer.