Re: [coreboot] [PATCH] Drop all pre-CBFS rom_address entries in Config.lb/devicetree.cb

[Stefan Reinauer]

Myles Watson wrote:
> On Wed, Oct 28, 2009 at 2:18 PM, Myles Watson <[e-mail]
> > wrote:
> On Wed, Oct 28, 2009 at 1:58 PM, Uwe Hermann <[e-mail]
> <mailto:[e-mail]>> wrote:
>
>     See patch.
>
> I think it would be nice to figure out what we do with the
> "onboard" device at the same time.
>
> Ping.  I think this patch is an improvement, but I didn't want the
> opportunity to remove more dead code pass by.  Any comments?

Acked-by: Stefan Reinauer  for removing all the
->onboard stuff.
>  from src/drivers/pci/onboard.c:
>
> static void onboard_enable(device_t dev)
> {
>     struct drivers_pci_onboard_config *conf;
>         conf = dev->chip_info;
>     dev->rom_address = conf->rom_address;
> }
>
> Does it make sense to change ROM handling so that only "onboard"
> devices can have their ROMs run?  That's the way it used to be, right?

No. Plugin cards (graphics cards) need to have their ROM run, too.

Stefan