[coreboot] Re: Asrock E350M1: Display regression in Linux

[HacKurx]

Le ven. 12 juin 2020 à 15:16, HacKurx  a écrit :
> Le lun. 8 juin 2020 à 19:10, Paul Menzel  a écrit :
> > Dear HacKurx,
> >
> > Am 04.06.20 um 12:49 schrieb Paul Menzel:
> > > Am 04.06.20 um 11:26 schrieb HacKurx:
> > > > Good morning, everyone,
> > > >
> > > > I hadn't updated my coreboot version for a long time on my Asrock
> > > > E350M1 card because of lack of time and because this one was on a very
> > >
> > > I guess you mean *board* and not *card*?
> > > > stable version. While trying to test the current 4.12 version, I
> > > > encountered problems in Debian 10.
> > >
> > > What coreboot version did you use before?
> > > > Indeed, there is a bad graphical detection, the resolution of my hdmi
> > > > output went from 1360x768 to 720x400 pixels.
> > > > Xorg indicates that the drm device cannot be opened :
> > > > (EE) open /dev/dri/card0: No such file or directory
> > > >
> > > > I once had a Oops kernel message:
> > > > https://pastebin.com/uZLZyYrq
> > >
> > > For the future, please attach the logs to the message, so people can
> > > read it offline.
> > >
> > > I paste the error below.
> > > > [    4.816957] [drm] Found smc ucode version: 0x00010601
> > > > [    4.817038] BUG: unable to handle kernel NULL pointer dereference
> > > > at 0000000000000000
> > > > [    4.817171] PGD 0 P4D 0
> > > > [    4.817225] Oops: 0000 [#1] SMP NOPTI
> > > > [    4.817280] CPU: 1 PID: 111 Comm: systemd-udevd Not tainted
> > > > 4.19.0-9-amd64 #1 Debian 4.19.118-2
> > > > [    4.817338] Hardware name: ASROCK E350M1/E350M1, BIOS
> > > > 4.12-371-g3b8284f37a 05/28/2020
> > > > [    4.817478] RIP: 0010:sumo_dpm_enable+0x2ed/0x510 [radeon]
> > > > [    4.817603] Code: ff ff 80 bd 77 01 00 00 00 0f 85 ed 01 00 00 80
> > > > bd 7b 01 00 00 00 0f 85 d3 01 00 00 48 8b 8b a0 1d 00 00 48 8b 83 40
> > > > 1e 00 00 <48> 8b 31 48 8b 51 28 48 89 b0 80 01 00 00 48 8b 71 08 48 89
> > > > b0 88
> > > > [    4.817672] RSP: 0018:ffffad9980fab9c0 EFLAGS: 00010246
> > > > [    4.817727] RAX: ffff9ad1eb9d8c00 RBX: ffff9ad1eb0a0000 RCX:
> > > > 0000000000000000
> > > > [    4.817782] RDX: ffffad9981180000 RSI: ffff9ad1eb0a01e8 RDI:
> > > > ffff9ad1eb0a0178
> > > > [    4.817837] RBP: ffff9ad1eb9d8c00 R08: ffffad9980fab9a4 R09:
> > > > ffffad9980fab9a0
> > > > [    4.817893] R10: 0000000000000010 R11: 0000000000000000 R12:
> > > > ffff9ad1eb0a01e8
> > > > [    4.817948] R13: 0000000000000000 R14: ffffad9980fab9c0 R15:
> > > > ffffad9980fab9c4
> > > > [    4.818004] FS:  00007f94e95d7d40(0000) GS:ffff9ad1f7100000(0000)
> > > > knlGS:0000000000000000
> > > > [    4.818061] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [    4.818115] CR2: 0000000000000000 CR3: 000000026ba34000 CR4:
> > > > 00000000000006e0
> > > > [    4.818171] Call Trace:
> > > > [    4.818295]  radeon_pm_init+0x5a5/0x720 [radeon]
> > > > [    4.818493]  evergreen_init+0x149/0x370 [radeon]
> > > > [    4.818680]  radeon_device_init+0x681/0xcd0 [radeon]
> > > > [    4.818868]  radeon_driver_load_kms+0x77/0x260 [radeon]
> > > > [    4.819037]  drm_dev_register+0x109/0x140 [drm]
> > > > [    4.819195]  drm_get_pci_dev+0x8f/0x170 [drm]
> > > > [    4.819316]  radeon_pci_probe+0xf9/0x1b0 [radeon]
> > > > [    4.819450]  local_pci_probe+0x41/0x90
> > > > [    4.819512]  pci_device_probe+0xff/0x1b0
> > > > [    4.819574]  really_probe+0x24b/0x3b0
> > > > [    4.819635]  driver_probe_device+0xb3/0xf0
> > > > [    4.819696]  __driver_attach+0xea/0x110
> > > > [    4.819757]  ? driver_probe_device+0xf0/0xf0
> > > > [    4.819818]  bus_for_each_dev+0x77/0xc0
> > > > [    4.819879]  ? klist_add_tail+0x3b/0x70
> > > > [    4.819939]  bus_add_driver+0x152/0x230
> > > > [    4.820000]  ? 0xffffffffc04d8000
> > > > [    4.820058]  driver_register+0x6b/0xb0
> > > > [    4.820118]  ? 0xffffffffc04d8000
> > > > [    4.820178]  do_one_initcall+0x46/0x1c3
> > > > [    4.820240]  ? _cond_resched+0x15/0x30
> > > > [    4.820300]  ? kmem_cache_alloc_trace+0x172/0x1e0
> > > > [    4.820363]  do_init_module+0x5a/0x210
> > > > [    4.820423]  load_module+0x2167/0x23d0
> > > > [    4.820487]  ? __do_sys_finit_module+0xad/0x110
> > > > [    4.820547]  __do_sys_finit_module+0xad/0x110
> > > > [    4.820608]  do_syscall_64+0x53/0x110
> > > > [    4.820666]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > > > [    4.820726] RIP: 0033:0x7f94e9dc1f59
> > > > [    4.820783] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00
> > > > 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24
> > > > 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 07 6f 0c 00 f7 d8 64 89
> > > > 01 48
> > > > [    4.820945] RSP: 002b:00007ffea54a8a88 EFLAGS: 00000246 ORIG_RAX:
> > > > 0000000000000139
> > > > [    4.821017] RAX: ffffffffffffffda RBX: 000055e86f8caa50 RCX:
> > > > 00007f94e9dc1f59
> > > > [    4.821076] RDX: 0000000000000000 RSI: 00007f94e9cc6cad RDI:
> > > > 000000000000000f
> > > > [    4.821136] RBP: 00007f94e9cc6cad R08: 0000000000000000 R09:
> > > > 0000000000000000
> > > > [    4.821196] R10: 000000000000000f R11: 0000000000000246 R12:
> > > > 0000000000000000
> > > > [    4.821256] R13: 000055e86f8ec990 R14: 0000000000020000 R15:
> > > > 000055e86f8caa50
> > > > [    4.821317] Modules linked in: radeon(+) i2c_algo_bit ttm ahci
> > > > drm_kms_helper libahci ohci_pci(+) libata ehci_pci ohci_hcd ehci_hcd
> > > > drm r8169 usbcore psmouse realtek scsi_mod libphy i2c_piix4 usb_common
> > > > thermal button
> > > > [    4.821501] CR2: 0000000000000000
> > > > [    4.821598] ---[ end trace 4ecc1988915ecede ]---
> > > > [    4.821795] RIP: 0010:sumo_dpm_enable+0x2ed/0x510 [radeon]
> > > > [    4.821924] Code: ff ff 80 bd 77 01 00 00 00 0f 85 ed 01 00 00 80
> > > > bd 7b 01 00 00 00 0f 85 d3 01 00 00 48 8b 8b a0 1d 00 00 48 8b 83 40
> > > > 1e 00 00 <48> 8b 31 48 8b 51 28 48 89 b0 80 01 00 00 48 8b 71 08 48 89
> > > > b0 88
> > > > [    4.822091] RSP: 0018:ffffad9980fab9c0 EFLAGS: 00010246
> > > > [    4.822151] RAX: ffff9ad1eb9d8c00 RBX: ffff9ad1eb0a0000 RCX:
> > > > 0000000000000000
> > > > [    4.822211] RDX: ffffad9981180000 RSI: ffff9ad1eb0a01e8 RDI:
> > > > ffff9ad1eb0a0178
> > > > [    4.822270] RBP: ffff9ad1eb9d8c00 R08: ffffad9980fab9a4 R09:
> > > > ffffad9980fab9a0
> > > > [    4.822330] R10: 0000000000000010 R11: 0000000000000000 R12:
> > > > ffff9ad1eb0a01e8
> > > > [    4.822390] R13: 0000000000000000 R14: ffffad9980fab9c0 R15:
> > > > ffffad9980fab9c4
> > > > [    4.822451] FS:  00007f94e95d7d40(0000) GS:ffff9ad1f7100000(0000)
> > > > knlGS:0000000000000000
> > > > [    4.822522] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [    4.822580] CR2: 0000000000000000 CR3: 000000026ba34000 CR4:
> > > > 00000000000006e0
> >
> > Let’s try to find the error in the Linux driver code.
> >
> > Please install the the debug symbols with
> >  apt install linux-image-<our version>-dbg
> >
> > and run the script from the Linux tree.
> >  scripts/faddr2line vmlinux sumo_dpm_enable+0x2ed/0x510
> >
> > I believe, you can also use `scripts/decodecode` feed it the Linux
> > messages. It will parse the `Code:` line.
> >
> > […]
> >
> > Kind regards,
> >
> > Paul
>
> Hi Paul,
>
> I'm not a gdb professional, so I hope this is okay for you.
>
> loic@E350M1:/usr/src/linux-source-4.19$ ./scripts/faddr2line
> /usr/lib/debug/boot/vmlinux-4.19.0-9-amd64 sumo_dpm_enable+0x2ed/0x510
> no match for sumo_dpm_enable+0x2ed/0x510
>
> $ gdb /usr/lib/debug/boot/vmlinux-4.19.0-9-amd64
> Reading symbols from /usr/lib/debug/boot/vmlinux-4.19.0-9-amd64...done.
> (gdb) list *(sumo_dpm_enable+0x2ed/0x510)
> No symbol "sumo_dpm_enable" in current context.
> (gdb) add-symbol-file
> '/lib/debug/lib/modules/4.19.0-9-amd64/kernel/drivers/gpu/drm/radeon/radeon.ko'
> add symbol table from file
> "/lib/debug/lib/modules/4.19.0-9-amd64/kernel/drivers/gpu/drm/radeon/radeon.ko"
> (y or n) y
> Reading symbols from
> /lib/debug/lib/modules/4.19.0-9-amd64/kernel/drivers/gpu/drm/radeon/radeon.ko...done.
> (gdb) list *(sumo_dpm_enable+0x2ed/0x510)
> 0xa8830 is in sumo_dpm_enable (./drivers/gpu/drm/radeon/sumo_dpm.c:1204).
> 1199        pi->requested_ps = *new_ps;
> 1200        pi->requested_rps.ps_priv = &pi->requested_ps;
> 1201    }
> 1202
> 1203    int sumo_dpm_enable(struct radeon_device *rdev)
> 1204    {
> 1205        struct sumo_power_info *pi = sumo_get_pi(rdev);
> 1206
> 1207        if (sumo_dpm_enabled(rdev))
> 1208            return -EINVAL;
>
> (gdb) disassemble /m sumo_dpm_enable
> [...]
> 1192    static void sumo_update_requested_ps(struct radeon_device *rdev,
> 1193                         struct radeon_ps *rps)
> 1194    {
> 1195        struct sumo_ps *new_ps = sumo_get_ps(rps);
> 1196        struct sumo_power_info *pi = sumo_get_pi(rdev);
> 1197
> 1198        pi->requested_rps = *rps;
> 1199        pi->requested_ps = *new_ps;
> 1200        pi->requested_rps.ps_priv = &pi->requested_ps;
> 1201    }
> 1202
> 1203    int sumo_dpm_enable(struct radeon_device *rdev)
> 1204    {
>    0x00000000000a8830 <+0>:    callq  0xa8835 <sumo_dpm_enable+5>
>    0x00000000000a8835 <+5>:    push   %r15
>    0x00000000000a8837 <+7>:    push   %r14
>    0x00000000000a8839 <+9>:    push   %r13
>    0x00000000000a883b <+11>:    push   %r12
>    0x00000000000a883d <+13>:    push   %rbp
>    0x00000000000a883e <+14>:    push   %rbx
>    0x00000000000a883f <+15>:    sub    $0x10,%rsp
>    0x00000000000a8843 <+19>:    mov    0x1e40(%rdi),%rbp
>    0x00000000000a884a <+26>:    mov    %gs:0x28,%rax
>    0x00000000000a8853 <+35>:    mov    %rax,0x8(%rsp)
>    0x00000000000a8858 <+40>:    xor    %eax,%eax
>
> 1205        struct sumo_power_info *pi = sumo_get_pi(rdev);
> [...]
>
> Thank you very much.
>
> Best regards,
>
> Loic

Hello again, Paul,

Indeed the problem comes indeed VGA Option ROM. We use different versions.

ASRock had modified several times the detection function of the VGA
cards and an intermediate version is not compatible with the 2 commits
that I had designated.
When comparing printable strings from different versions of vgabios, I
found the following differences.

pci1002,9802.rom from the Wiki use: IBMM
intermediate version incompatible with VFCT use: IBM
latest vgabios (version ASRock 2.10) use: IBM0

Problem solved. Thank you for your time.

Best Regards,

Loic