Hi All:
Thanks for details process, I shall follow in the future commit.
I ran into username problem during commit:
Authentication realm: svn://coreboot.org:3690 LinuxBIOS Password for 'vlim': Authentication realm: svn://coreboot.org:3690 LinuxBIOS Username: VincentLim Password for 'VincentLim': Authentication realm: svn://coreboot.org:3690 LinuxBIOS Username: VincentLim Password for 'VincentLim': svn: Commit failed (details follow): svn: Authentication error from server: Username not found svn: Your commit message was left in a temporary file: svn: '/proj/simnow-data3/users/vlim/coreboot/coreboot/coreboot-v2/src/cpu/amd /svn-commit.3.tmp' beemer:/proj/simnow-data3/users/vlim/coreboot/coreboot/coreboot-v2/src/c pu/amd/m
I checked out using command "svn co svn://VincentLim@coreboot.org/repos/trunk/coreboot-v2
Maybe I do not have set-up/permission to check-in code yet ?
Best Regards,
Vincent Lim SimNow Team Performance CoE Central Engineering T 512.602.1618 F 512.602.7745
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Peter Stuge Sent: Saturday, April 25, 2009 8:01 AM To: coreboot@coreboot.org Subject: Re: [coreboot] Newbie source commit question
Hi Vincent,
Lim, Vincent wrote:
I would like to add the family10h Rev C0-C2 support to coreboot and
Great!
I just wanted to make sure I've got the procedure right.
As you may know by now, this is how it goes:
1. Work in local development tree 2. Generate patch file with svn diff 3. Send email to the list with log message, maybe some extra explanations, Signed-off-by: and the patch file. 4. Wait for Acked-by: or discussion. 5. If Acked-by: then commit with log message, which ends with Signed-off-by: and all Acked-by: received in 4.
In 3. some like to include the patch contents in the email body, some attach the file, some do both. I like to use attachments because then I don't have to worry about my mail program reformatting the patch in case anyone wants to apply it to their development trees.
When using attachments, please check that the MIME type for the attachment is set to text/plain (often automatic if the file name ends with .patch) to allow easier reading for all list recipients.
Others can improve upon your patch, and then send a new patch with their Signed-off-by: added to yours. In that case both developers who signed off usually watch the discussion or the first can even ack the new changes of the second. This is not very common, but has happened.
For trivial things such as reformatting, wording changes, and more, it is fine to self-ack, ie. skip 2. 3. and 4. and instead commit directly with Signed-off-by: and Acked-by: yourself.
Hope this helps!
//Peter