Re: [LinuxBIOS] [patch] flashrom: w863xx helpers and w86327hf_gpio42_raise

[Luc Verhaegen]

On Fri, May 04, 2007 at 06:47:14AM +0200, Peter Stuge wrote:
> On Fri, May 04, 2007 at 06:10:29AM +0200, Luc Verhaegen wrote:
> > You can take this sort of thing very far
> > A single bitwise clear is:
> >    wbsio_mask(reg, 0x00, 0x10);
> >
> > A single bitwise set is:
> >    wbsio_mask(reg, 0x10, 0x10);
>
> Sorry about not looking at the code properly. I should go do
> something else now until I have time to do things properly
> around here.
>
> I assumed _mask was _clear and did not realize it could be used both
> for set and clear. The code is fine. I'd wish for a more descriptive
> but still consice name but can't come up with one.

I've used these things for at least three years now, i too can't come up 
with anything better.
> Committed r2627.

Thanks :)

Luc Verhaegen.