Re: [coreboot] [PATCH] Superiotool: Add VT82C686

[Uwe Hermann]

On Sat, Jan 23, 2010 at 08:12:04AM -0800, Sean Nelson wrote:
> > > > Add VIA VT82C686A/VT82C686B support to superiotool.
> > > > The patch as-is will likely not detect the Super I/O due to missing PCI
> > > > functionality in superiotool, but you might get lucky.
> > > >
> > > > This adds an additional requirement to superiotool: libpci. I have made
> > > > the PCI code conditional on PCI_SUPPORT for now.
> > > >
> > > > Signed-off-by: Carl-Daniel Hailfinger
> > >
> > > Ping?
> >
> > I guess nobody has that hardware anymore, but anyways
> >
> > Acked-by: Stefan Reinauer

Thanks, I took the freedom to commit a slightly changed (and
hardware-tested) version of the patch in r5047.

I changed some minor cosmetics in via.c, added whitespace and missing
newlines, moved the PCI_SUPPORT checks to superiotool.h (and conditionally
add via.o in the Makefile), introduced a config option for PCI support in
the Makefile, and added pci.c which has the bare minimum, simple PCI
stuff we need.
> I think I still have a machine that uses it, I'll have to dig it out
> and do some
> testing and such. I'll report back when I get the time.

I tested the committed patch on a VT82686A box, but please test on your
board nevertheless to be sure (especially so if you have a VT82686B).

Thanks, Uwe.