Re: [coreboot] [patch] AMD S1G1 socket in kconfig

[Uwe Hermann]

On Thu, Aug 27, 2009 at 05:14:41PM +0300, Cristi Magherusan wrote:
> Please see the attached patch.

This was r4602.
> diff --git a/src/cpu/amd/socket_S1G1/Kconfig b/src/cpu/amd/socket_S1G1/Kconfig
> new file mode 100644
> index 0000000..905b407
> --- /dev/null
> +++ b/src/cpu/amd/socket_S1G1/Kconfig
> @@ -0,0 +1,25 @@
> +config CPU_AMD_SOCKET_S1G1
>    bool
> default false

Whitespace looks broken above, should be one TAB per line.
> +config K8_REV_F_SUPPORT
> int
> default 1
> depends on CPU_AMD_SOCKET_S1G1

This should be bool and y, I think.
> +config CPU_SOCKET_TYPE
> hex
> default 0x12
> depends on CPU_AMD_SOCKET_S1G1
>
> +config K8_HT_FREQ_1G_SUPPORT
> hex
> default 1

Same here, bool and y.

Uwe.