Re: [coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

[Mohan]

On 09/11/14 18:16, Idwer Vollering wrote:
> 2014-09-11 9:34 GMT+02:00 Mohan :
> > Hi,
> >
> > This is a tentative patch for S3 suspend/resume support in MinnowMax Board.
>
> (..)

??

This patch is more of a requests for comments..
> > Comments, suggestion, corrections are welcome.
> > I would like to get it added it, can anyone help me ?
>
> Certainly. Have you read this subpage,
> http://www.coreboot.org/Development_Guidelines#Creating_Patches ? It
> will answer most of your questions.

I need to register at  http://review.coreboot.org/ and submit my patch 
using git, right ?

Also need to add a "Signed-off-by:" to my patch.

Thanks,
Mohan