-----Original Message----- From: Jordan Crouse [mailto:jordan.crouse@amd.com] Sent: Monday, May 05, 2008 5:58 PM To: Myles Watson Cc: coreboot@coreboot.org Subject: Re: buildrom: cleanup package includes (updated)
On 05/05/08 17:29 -0600, Jordan Crouse wrote:
On 05/05/08 17:02 -0600, Myles Watson wrote:
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-
bounces@coreboot.org]
On Behalf Of Jordan Crouse Sent: Monday, May 05, 2008 3:55 PM To: coreboot@coreboot.org Subject: [coreboot] buildrom: cleanup package includes (updated)
Attached is an updated version of the patch I sent before that streamined the .mk files that are included in buildrom. This
version
is updated with the latest and greatest from Myles and everybody.
Tested with all payloads + coreinfo, and hd8mr + kernel (I'm going
to
test the other platforms with kernel, but I didn't want to wait
around
for them to finish building).
Acked-by: Myles Watson mylesgw@gmail.com
Thanks - I am going to wait on this until tomorrow. Coreboot-v2 +
kernel
failed on 13 of 17 targets (and only 3 failures are due to missing .mk
files).
I don't know if this is becuase of my patch, my test harness, or
something
else. Either way, it is best that I hold off until I can debug it more fully.
I had a second to build one of the failing platforms at random (s2882), and the error ended up being that the kernel was too big for the ROM. I'm going to go ahead and re-run the entire test with verboseness turned on over night to get a clear picture of which platforms need love.
Several of the platforms have kernels that have never fit for me. I always figured the problem was my broken toolchain. I only test that changes don't break things that were working.
Myles