Re: [coreboot] [patch] flashrom for Geode

[Peter Stuge]

On Thu, Jan 24, 2008 at 03:43:31PM -0700, Marc Jones wrote:
> For correctness do a read-modify-write of the ROM write-protect area.

Thank you.
> Correctly disable the ROM area Write Protect bit in the Geode LX.
>
> signed-off by: Marc Jones

Not tested, but:

Acked-by: Peter Stuge
> Index: LinuxBIOSv2/util/flashrom/chipset_enable.c
>
> --- LinuxBIOSv2.orig/util/flashrom/chipset_enable.c	2008-01-24 15:13:50.000000000 -0700
> +++ LinuxBIOSv2/util/flashrom/chipset_enable.c	2008-01-24 15:14:46.000000000 -0700
> @@ -256,7 +256,7 @@
>    close(fd_msr);
>    if (buf[7] != 0x22) {
>    	printf("Enabling Geode MSR to write to flash.\n");
> buf[7] = 0x22;
> buf[7] &= 0xFB; 
> fd_msr = open("/dev/cpu/0/msr", O_WRONLY);
> if (!fd_msr) {
> 	perror("open msr");