Re: [LinuxBIOS] [PATCH] v3 drop malloc, clean up device model

[Stefan Reinauer]

* ron minnich  [070629 18:36]:
> Let's drop the "gcc hack" comment, it no longer applies.

dropped.
> if (!dev)
> printk(BIOS_DEBUG, "%s: No constructor, going with empty dev",
>        dev_id_string(devid));
> return NULL;
>
> are you missing a spin_unlock here? If we are doing lock/unlock then
>  the failure case should probably be a goto Error in the kernel style,
>  so we don' t leave a dangling lock.

Oh yeah! Even though this case does usually mean we can not really
continue.

new patch ...
Signed-off-by: Stefan Reinauer