-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Peter Stuge Sent: Monday, November 17, 2008 1:49 PM To: coreboot@coreboot.org Subject: Re: [coreboot] r1040 - coreboot-v3/superio/winbond/w83627thg
svn@coreboot.org wrote:
Fix/finish the Winbond W83627THF/THG dts.
..
+++ coreboot-v3/superio/winbond/w83627thg/dts 2008-11-17 20:40:39
UTC
(rev 1040)
@@ -20,8 +20,23 @@
{ device_operations = "w83627thg_ops";
/* To override any of these, put the over-ride in mainboard dts. */
/* Floppy */
floppydev = "0";
floppyenable = "0";
floppyio = "0x3f0";
floppyirq = "6";
floppydrq = "2";
I would like to veto this style - it's not the dts way, it's the v2 way.
I implemented two different ways, and this one was the one that was accepted. No one liked the idea of having a generic dts for PNP devices, and no one liked the idea of having a specific dts for each function of every SuperIO.
Sorry if there is already consensus on this issue, but I would really like something more dtsy than that for the pnps.
Suggestions? Code?
Thanks, Myles