Re: [coreboot] [PATCH] flashrom: Add support for 8 new chips, fix up 2 existing chips

[Uwe Hermann]

Patch is

Acked-by: Uwe Hermann

On Mon, Nov 03, 2008 at 02:24:13AM +0100, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
> > +#define MX_29F002B		0x34
> > +#define MX_29F002T		0xB0
>
> Yeah. Please don't do this. Put them in the struct.

I don't remember the outcome of that flashrom discussion a while ago,
but either way, this shouldn't hold up the commit. If we want to get rid
of the #defines that should happen in one commit for all of the chips.

Uwe.