Re: [coreboot] [PATCH] Enable maximum decoded range for VT8237*

[Stefan Reinauer]

On 4/20/10 11:47 PM, Rudolf Marek wrote:
> Hello,
>
> Attached patch adds support for tinybootblock on VT8237* to decode
> whole flash
> independent of strapping, making larger flashes work again (as it was in
> pre-tiny bootblock era)
>
> Signed-off-by: Rudolf Marek
>
> I had a strange problem:
>
> #include <arch/io.h>
> #include <arch/romcc_io.h>
> #include <device/pci_ids.h>
>
> static void bootblock_southbridge_init(void) {
>
> device_t dev;
>
> /* Power management controller */
> dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA,
> PCI_DEVICE_ID_VIA_VT8237R_LPC), 0);
>
> if (dev == PCI_DEV_INVALID) {
> /* Power management controller */
> dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA,
> PCI_DEVICE_ID_VIA_VT8237S_LPC), 0);
>
> if (dev == PCI_DEV_INVALID)
> return;

^^^^^^^^^^^^^^^^^^^^^^^^^^^^

And you are sure that dev is not PCI_DEV_INVALID at this point?
> }
> pci_write_config8(dev, 0x41, 0x7f);
> }