Re: [coreboot] [PATCH]: Add superio SMSC sch4304 support.

[Uwe Hermann]

Hi,

On Thu, Nov 26, 2009 at 10:11:43AM +0800, Bao, Zheng wrote:
> Does anyone review it before it is drowned?

I can't find the datasheet right now, but if the ID is 0x90 and
the numbers you added in that table are the Super I/O LDNs, then
this is

Acked-by: Uwe Hermann

The Super I/O only has FDC PP SP1 SP2 KBC XBUS RT as LDNs, correct?
>   // Chip   FDC PP SP1 SP2 RTC KBC AUX XBUS HWM GAME PME MPU RT ACPI SMB

[...]
> {SCH3112,  {0, 3, 4,  5, -1,  7, -1,  -1, -1,  -1, -1, -1, 10, -1, -1}},
>    {SCH5307,  {0, 3, 4,  5, -1,  7, -1,  -1,  8,  -1, -1, -1, 10, -1, -1}},
>    {SCH5027D, {0, 3, 4,  5, -1,  7, -1,  -1, -1,  -1, -1, -1, 10, -1, 11}},
> {SCH4304,  {0, 3, 4,  5, -1,  7, -1,  11, -1,  -1, -1, -1, 10, -1, -1}},

Uwe.