Re: [coreboot] [PATCH] Add support for high tables to via vt8454c

[Myles Watson]

On Tue, Apr 28, 2009 at 9:07 AM, Patrick Georgi  wrote:
> Am 28.04.2009 17:04, schrieb Myles Watson:
> > This patch fixes the build for K8 targets that don't have ACPI, so
> > defaulting to HAVE_HIGH_TABLES breaks them.
>
> HAVE_HIGH_TABLES isn't only useful for ACPI tables, so I have to disagree on
> this part of the patch (in src/northbridge/amd/amdk8/Config.lb)
>
> I committed a fix (tested on _clean_ trees, that was the problem in my tests
> for my last patch) that guards ACPI table writing with #if HAVE_ACPI_TABLES.
>
> As for the other stuff, what's its purpose?

Showing you that I wasn't very careful with svn diff :)

Myles