Re: [coreboot] [commit] r6055 - in trunk/src: . lib

[Myles Watson]

On Tue, Nov 9, 2010 at 7:53 PM, Stefan Reinauer
 wrote:
> On 09.11.2010, at 18:08, "Myles Watson"  wrote:
>
> Modified: trunk/src/lib/malloc.c
>
> ==========================================================================
>
> ====
>
> --- trunk/src/lib/malloc.c    Wed Nov 10 01:14:32 2010    (r6054)
>
> +++ trunk/src/lib/malloc.c    Wed Nov 10 03:00:32 2010    (r6055)
>
> @@ -4,7 +4,7 @@
>
> #if CONFIG_DEBUG_MALLOC
>
> #define MALLOCDBG(x...) printk(BIOS_SPEW, x)
>
> This would be the easy place to make sure that you could see the messages.
> #define MALLOCDBG(x...) printk(CONFIG_DEFAULT_CONSOLE_LOGLEVEL, x)
>
> I think keeping them at SPEW is fine,...  Otherwise we end up with images
> printing that information at ie error log level making it impossible to
> enable the option in production images at all.

How about CONFIG_MAXIMUM_CONSOLE_LOGLEVEL, then?  I was responding to this:

+config DEBUG_MALLOC
+       def_bool n
+
 # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional
 # printk(BIOS_DEBUG, ...) calls.
+if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8
 config DEBUG_MALLOC
       bool "Output verbose malloc debug messages"
       default n
-       depends on DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8

I think the idea is that if someone enables malloc debugging they want
to be able to see the messages.  If you leave it SPEW and set MAX to
DEBUG ...

Thanks,
Myles