Re: [coreboot] [RFC] Network console for coreboot

[Myles Watson]

Before you commit, I have some suggestions:

I don't think it should default to yes.

+config CONSOLE_NE2K
+	bool "Network console over NE2000 compatible Ethernet adapter"
+	default y
+	help

A little trivial white space cleanup before you commit.

Warning: trailing whitespace in lines
70,104,110,113,240,243,244,246,255,257,330,342,344,418,420 of
src/lib/ne2k.c

Now that warnings are errors, it's time to add the timeout.

+#warning "Add timeout"

Thanks,
Myles