Re: [coreboot] [v2] r4188 - trunk/coreboot-v2/targets/hp/dl145_g3

[Stefan Reinauer]

On 23.04.2009 0:47 Uhr, Myles Watson wrote:
> > -----Original Message-----
> > From: [e-mail] [mailto:[e-mail]]
> > On Behalf Of [e-mail]
> > Sent: Wednesday, April 22, 2009 4:43 PM
> > To: [e-mail]
> > Subject: [coreboot] [v2] r4188 - trunk/coreboot-v2/targets/hp/dl145_g3
> >
> > Author: stepan
> > Date: 2009-04-23 00:43:02 +0200 (Thu, 23 Apr 2009)
> > New Revision: 4188
> >
> > Added:
> >    trunk/coreboot-v2/targets/hp/dl145_g3/Config-abuild.lb
> > Log:
> > fix compilation of hp dl145
> >
> > Signed-off-by: Stefan Reinauer 
> > Acked-by: Stefan Reinauer
>
> Thanks for fixing it.  I didn't think I'd need to add Config-abuild.lb for
> this board.  Tyan s2892 doesn't have one.
>
> Is there a rule?

If there is none, abuild will create one with a ROM_IMAGE_SIZE of
0x17000 (92kb).. Unfortunately abuild can not figure out how much space
is needed to fit the image before the linker fails.
This is one thing where further CBFS integration in v2 can bring us a
big gain... we could drop 90% of the Config-abuild.lb files (plus the
ugly image calculation that Carl-Daniel factored out so nicely)

Stefan