Re: [coreboot] [PATCH 5/6] Changes required to the device allocator

[Stefan Reinauer]

Myles Watson wrote:
> > -----Original Message-----
> > From: Stefan Reinauer [mailto:[e-mail]]
> > Sent: Tuesday, October 28, 2008 9:16 PM
> > To: Myles Watson
> > Cc: 'Coreboot'
> > Subject: Re: [coreboot] [PATCH 5/6] Changes required to the device
> > allocator
> >
> > Myles Watson wrote:
> > > > Changes required to the device allocator:
> > > > leave a hole for mmapped PCIe config space if
> > >
> > > CONFIG_PCIE_CONFIGSPACE_HOLE
> > > > is set.
> > > > Mask moving bits to 32bit when resources are not supposed above 4G.
> > >
> > > Linux
> > > > does not like this, even though the resource is disabled.
> > > >
> > > > Signed-off-by: Stefan Reinauer
> > >
> > > Looks good.  would it be better to set the resource to 0 instead of to
> > > moving bits?  Then there would not be a need for the special case.  It
> >
> > also
> > > makes it easier to read the config space.
> > >
> > > Acked-by: Myles Watson
> >
> > Thanks! r3699.
> >
> > According to Ron and Eric, setting the resource to 0 will not work on
> > some devices. I know factory bios has done it on at least the bridges
> > I've seen so I am not sure what the right behavior would be. Setting
> > them to 0 would seem the right thing.
>
> Should we consider fix-ups for broken boards, then?  How common is it?

Yes, that's what I've been thinking too.