Re: [coreboot] patch: add Kconfig support for v3 north

[Uwe Hermann]

On Fri, Jan 25, 2008 at 09:12:45AM -0800, ron minnich wrote:
> attached
> Add Kconfig files for the northbridge. Currently we only need this for the geodelx, 
> so we can select nrv2b decompression.
>
> This has been tested in build and behaves as we want it to: nrv decompression 
> is enabled and the code compiled in.
>
> Signed-off-by: Ronald G. Minnich

Breaks for me.

$ make menuconfig
  CHECK   build/dochecklxdialog
  HOSTCC  build/util/kconfig/lxdialog/checklist.o
  HOSTCC  build/util/kconfig/lxdialog/menubox.o
  HOSTCC  build/util/kconfig/lxdialog/textbox.o
  HOSTCC  build/util/kconfig/lxdialog/yesno.o
  HOSTCC  build/util/kconfig/lxdialog/inputbox.o
  HOSTCC  build/util/kconfig/lxdialog/util.o
  HOSTCC  build/util/kconfig/lxdialog/lxdialog.o
  HOSTCC  build/util/kconfig/lxdialog/msgbox.o
  HOSTCC  build/util/kconfig/lxdialog/lxdialog
  HOSTCC  build/util/kconfig/mconf.o
  HOSTCC  build/util/kconfig/zconf.tab.o
  HOSTCC  build/util/kconfig/mconf
northbridge/amd/geodelx/Kconfig:23: unexpected option "select"
make: *** [menuconfig] Error 1
> Index: Kconfig
>
> --- Kconfig	(revision 560)
> +++ Kconfig	(working copy)
> @@ -63,6 +63,7 @@
>  endmenu
>
> source mainboard/Kconfig
> +source northbridge/Kconfig

I think we removed the "middle layer" Kconfig files a while ago because
they were not needed? Do we need to add them again? I'd try to avoid it.
> source arch/x86/Kconfig
>  source lib/Kconfig
>  source device/Kconfig
> Index: northbridge/Kconfig
> ===================================================================
> --- northbridge/Kconfig	(revision 0)
> +++ northbridge/Kconfig	(revision 0)
> @@ -0,0 +1,24 @@
> +##
> +## This file is part of the LinuxBIOS project.
> +##
> +## Copyright (C) 2006 Segher Boessenkool 
> +## Copyright (C) 2006-2007 coresystems GmbH
> +## (Written by Stefan Reinauer  for coresystems GmbH)
> +## Copyright (C) 2007 Uwe Hermann

Only
  Copyright (C) 2008 Ronald G. Minnich 
for such trivial files, please. If we continue to add (C) lines for each
new copy of such one-liner files we'll end up with horribly long and
useless lists of crap.
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; version 2 of the License.
> +##
> +## This program is distributed in the hope that it will be useful,
> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +## GNU General Public License for more details.
> +##
> +## You should have received a copy of the GNU General Public License
> +## along with this program; if not, write to the Free Software
> +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> +##
>
> +source "northbridge/amd/Kconfig"
>
> +select COMPRESSION_NRV2B

Uwe.