For line 31 and 37 of src/include/x86/car.h, does cache mean L1 cache? If so, it might be nice to make the macros say l1 explicitly. Also, I agree with Myles on not having redundant comments.
It might also be nice for the comments before each macro to indicate which registers get trashed within the macro. Maybe even make the register name a parameter of the macro, though I'm not sure if that would make sense.
Also, {en,dis}able mtrr should document which mtrr is getting {en,dis}abled as it looks like a specific one and not all of them. The name of those macros should probably reflect which mtrr as well.
Thanks, wt
On Fri, Oct 1, 2010 at 2:27 PM, Uwe Hermann uwe@hermann-uwe.de wrote:
See patch.
abuilt-tested.
Uwe.
http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot