Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.

[Libra Li]

Hi,

I had fixing non-ascii characters in the comments.
    Thanks.

Signed-off: Libra Li

2009/11/25 Bao, Zheng
> I haven't apply your patch, but in your patch,
> line 140, 150, 159, 166, 175, 185, 194,
> have those chars.
>
> You can use the perl script to detect the non-ascii chars. I sense there
> should be another better way.
>
> #!/usr/bin/perl
>
> my($content, $len);
>
> open(FILE, "< tim5690_buzzer_2.patch") || die "Unable to open file small.
> <$!>\n";
>
> while( chomp($content = <FILE>) ) {
>    $len = length($content);
>    for( $i = 0; $i < $len; $i++ ) {
>        if( ord(substr($content, $i, 1)) > 127 )
>        {
>            print "$content\n";
>            last;
>        }
>    }
> }
> close(FILE);
>
> exit 0
> ~
>
> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Bao, Zheng
> Sent: Wednesday, November 25, 2009 11:32 AM
> To: Libra Li
> Cc: coreboot
> Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.
>
> There is some non-ascii characters in the comments. Please fix it.
> After that,
>
> Acked-by: Zheng Bao
>
> Zheng
> ________________________________________
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Libra Li
> Sent: Wednesday, November 25, 2009 9:46 AM
> To: Myles Watson
> Cc: coreboot
> Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.
>
> Hi, Myles, Coreboot,
> I had change EARLY_STAGE into __PRE_RAM__. It's okay.
> Thanks.
>
> Signed-off: Libra Li <[e-mail]>
>
> 2009/11/25 Myles Watson 
> 2009/11/24 Libra Li :
> > Hi,
> > This patch is buzzer function of TechNexion TIM-5690.
> > That isn't everyone needs. So I don't put in public areas.
> > Thanks.
> >
> > Signed-off: Libra Li <[e-mail]>
>
> Could you use __PRE_RAM__ instead of EARLY_STAGE?  Does it mean
> something different?
>
> Thanks,
> Myles