Re: [coreboot] [PATCH] Make hidden configuration flags visible (i945)

[Myles Watson]

On Thu, Sep 30, 2010 at 4:19 PM, Patrick Georgi  wrote:
> Hi,
>
> attached patch moves several config flags that, for historical reasons,
> were put in romstage.c into Kconfig.

+choice
+	prompt "Chipset variant"
+	default I945GM
+	depends on NORTHBRIDGE_INTEL_I945
+	help
+	  Different i945 variants require slightly different setup.
+
+config I945GM
+	bool "i945GM (Mobile) chipset"
+
+config I945GC
+	bool "i945GC chipset"
+
+endchoice

I don't think this should be exposed to the user.  A board Kconfig
should select it, but there shouldn't be a menu prompt for it.

Thanks,
Myles