Re: [coreboot] [commit] r5503 - trunk

[Stefan Reinauer]

On 4/26/10 6:26 PM, Peter Stuge wrote:
> repository service wrote:
> > So we move the .c file back to .hex (or other suffix? or delete?).
>
> ..
> > +++ trunk/Makefile	Mon Apr 26 14:27:18 2010	(r5503)
> > @@ -226,6 +226,8 @@
> >    iasl -p $$(basename $$@) -tc $$(basename $$@).asl
> >    mv $$(basename $$@).hex $$(basename $$@).c
> >    $(CC) $$(CFLAGS) $$(if $$(subst dsdt,,$$(basename $$(notdir $$@))), -DAmlCode=AmlCode_$$(basename $$(notdir $$@))) -c -o $$@ $$(basename $$@).c
> > # keep %.o: %.c rule from catching the temporary .c file after a make clean
> > mv $$(basename $$@).c $$(basename $$@).hex
>
> Is renaming files back and forth the best solution?

No. But one we have a patch for.
> Best would of course be a binary output mode from iasl. Is there one?
> I think Patrick mentioned this.

If you have a patch, I'll gladly ack it.

Stefan