Re: [LinuxBIOS] flashrom geodelx patch

[Tom Sylla]

This patch is not quite correct.

The MSR being written is RCONF_DEFAULT_MSR (0x1808). That MSR includes
SYSTOP (where RAM ends). That should be dynamic depending on the
amount of RAM in the system, you can't really just smash in a fixed
value. The correct thing to do is to read the MSR, clear WP of the
ROMRP field, and write it back. Doing it this way would make it proper
and much cleaner (and self-documented).

(if anyone wonders what the fields mean, just read the LX databook)

On 8/15/07, Ingmar Schraub  wrote:
> Add support for AMD Geode LX / CS5536 to the flashrom utility.
>
> Signed-off-by: Ingmar Schraub
>
> regards,
>
> Ingmar