Hello, Stefan
void get_cpu_rev() is print the cpu revision info, and the cpu information has been printed when doing the microcode patching before.
This function GET nothing back but print, The function name is a little bit confuse people, So can we remove this function?
-- kerry
-----Original Message----- From: Stefan Reinauer [mailto:stefan.reinauer@coreboot.org] Sent: Saturday, April 23, 2011 4:02 AM To: She, Kerry Cc: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH 3/4] RS780 DDI Lanes configure support
- She, Kerry Kerry.She@amd.com [110422 05:13]:
Hello,
RS780 DDI Lanes configure support
Signed-off-by: Kerry She Kerry.she@amd.com
Acked-by: Stefan Reinauer stefan.reinauer@coreboot.org
With this list getting longer, it might be nice to: a) make it a case (eax) { ... } construct instead b) print "CPU Rev is" first, then just print the name.
Index: src/southbridge/amd/rs780/early_setup.c
--- src/southbridge/amd/rs780/early_setup.c (revision 6481) +++ src/southbridge/amd/rs780/early_setup.c (working copy) @@ -166,6 +166,26 @@ printk(BIOS_INFO, "CPU Rev is K8_G0.\n"); else if (eax <= 0x100000) printk(BIOS_INFO, "CPU Rev is K8_G1.\n");
else if (eax == 0x100f21)printk(BIOS_INFO, "CPU Rev is Fam 10 DR_B1.\n");else if (eax == 0x100f22)printk(BIOS_INFO, "CPU Rev is Fam 10 DR_B2.\n");else if (eax == 0x100f23)printk(BIOS_INFO, "CPU Rev is Fam 10 DR_B3.\n");else if (eax == 0x100f2A)printk(BIOS_INFO, "CPU Rev is Fam 10 DR_BA.\n");else if (eax == 0x100f42)printk(BIOS_INFO, "CPU Rev is Fam 10 RB_C2.\n");else if (eax == 0x100f43)printk(BIOS_INFO, "CPU Rev is Fam 10 RB_C3.\n");else if (eax == 0x100f52)printk(BIOS_INFO, "CPU Rev is Fam 10 BL_C2.\n");else if (eax == 0x100f53)printk(BIOS_INFO, "CPU Rev is Fam 10 BL_C3.\n");else if (eax == 0x100f62)printk(BIOS_INFO, "CPU Rev is Fam 10 DA_C2.\n");else if (eax == 0x100f63)printk(BIOS_INFO, "CPU Rev is Fam 10 DA_C3.\n"); else if (eax <= 0x100f00) printk(BIOS_INFO, "CPU Rev is Fam 10.\n"); else