Re: [coreboot] Epia-m700 Patch

[Uwe Hermann]

On Fri, Jun 05, 2009 at 10:22:25AM -0500, bari wrote:
> Here's an untested epia-m700 patch. VIA vx800 + C7.
>
> Please review and feel free to clean it up.

Thanks, committed in r4342 with some changes, see below.
(boldly self-acked as you didn't supply a Signed-off-by, but
I guess it's not an issue here as neither of us wrote this code
AFAIK. I mentioned that the code is from OLPC in the commit message)

I'll start some cleanups on it soon. Do you also have a
target/.../* directory patch, or should we try to hack one
together (so that we can abuild-test the board)?
> Index: src/mainboard/via/epia-m700/dsdt.c
>
> --- src/mainboard/via/epia-m700/dsdt.c	(revision 0)
> +++ src/mainboard/via/epia-m700/dsdt.c	(revision 0)
> @@ -0,0 +1,17 @@
> +/*
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20051117 [Nov 17 2005]
> Copyright (C) 2000 - 2005 Intel Corporation
> Supports ACPI Specification Revision 3.0
> Compilation of "dsdt.asl" - Mon Mar 02 10:15:04 2009
> C source code output

I replaced this and added the usual GPL-header as in the other files
(Copyright 2009 OLPC, GPLv2-or-later). Using a GPL header is ok for
the one-liner below, the _real_ DSDT is generated (and overwrites
this file) anyway (and that file is not GPL, of course).

Please scream loudly if the license header is incorrect (i.e.
if OLPC devs prefer GPLv2 vs. GPLv2-or-later, though the other
files in this patch seem to suggest GPLv2-or-later).
> */
>
> +unsigned char AmlCode_dsdt[] =
> +{
> +0x44,0x53,0x44,0x54,0x0F,0x3C,0x00,0x00,
> +//remove for lincense issue
> +};
> Index: src/mainboard/via/epia-m700/get_dsdt
>
> --- src/mainboard/via/epia-m700/get_dsdt	(revision 0)
> +++ src/mainboard/via/epia-m700/get_dsdt	(revision 0)

Added the missing GPL header here, too.
> Index: src/mainboard/via/epia-m700/ssdt.c
>
> --- src/mainboard/via/epia-m700/ssdt.c	(revision 0)
> +++ src/mainboard/via/epia-m700/ssdt.c	(revision 0)
> @@ -0,0 +1,17 @@
> +/*
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20051117 [Nov 17 2005]
> Copyright (C) 2000 - 2005 Intel Corporation
> Supports ACPI Specification Revision 3.0
> Compilation of "ssdt.asl" - Tue Feb 10 17:38:20 2009
> C source code output

Replaced with a GPL-header, see above.
> */
>
> +unsigned char AmlCode_ssdt[] =
> +{
> 0x53,0x53,0x44,0x54,0xA7,0x01,0x00,0x00,  /* 00000000    "SSDT...." */
>
> +// remove for lincese issue
> +};

Uwe.