Re: [coreboot] [PATCH] Update the document of CBFS

[Hamo]

Ping...
Comments are welcome...

On Fri, Apr 22, 2011 at 8:03 AM, Hamo  wrote:
> On Fri, Apr 22, 2011 at 3:46 AM, Jonathan A. Kollasch
>  wrote:
> > On Thu, Apr 21, 2011 at 09:22:39PM +0800, Hamo wrote:
> > > CBFS document is a little old since the structure of it has changed a
> > > lot specially CBFS master header.
> > > This patch updated  the document to show the newest structure of CBFS.
> > >
> > > Signed-off-by: Yang Bai
> > > Index: documentation/cbfs.txt
> > >
> > > --- documentation/cbfs.txt    (revision 6534)
> > > +++ documentation/cbfs.txt    (working copy)
> > > @@ -144,10 +144,13 @@
> > >  The following is the structure of the master header:
> > >
> > > struct cbfs_header {
> > > unsigned int magic;
> > > unsigned int size;
> > > unsigned int align;
> > > unsigned int offset;
> > > u32 magic;
> > >    u32 version;
> > >    u32 romsize;
> > >    u32 bootblocksize;
> > > u32 align;
> > > u32 offset;
> > > u32 pad[2];
> > >
> > > };
> >
> > Any particular reason to not use the C99 uintXX_t types in the docs?
> >    Jonathan Kollasch
>
> I don't know. The code style is a little strange. In file
> src/include/cbfs.h, uXX is used but in file util/cbfstool/common.h,
> C99 style is used.
>
> Chinese Name: 白杨
> Nick Name: Hamo
> Homepage: http://hamobai.com/
> GPG KEY ID: 0xA4691A33
> Key fingerprint = 09D5 2D78 8E2B 0995 CF8E  4331 33C4 3D24 A469 1A33