Re: [coreboot] K8 RAMinit problematic code

[ron minnich]

On Mon, Sep 1, 2008 at 10:10 AM, Carl-Daniel Hailfinger
 wrote:
> Sorry, I meant that
>
> struct sys_info *sysinfox = ((CONFIG_LB_MEM_TOPK<<10) - DCACHE_RAM_GLOBAL_VAR_SIZE);
>
> is broken beyond repair. Basically, that code tries to establish a new
> location for global variables without telling anyone.

yow! that's supposed to have been gone already! I wonder if a patch got lost.
> > We're going to write this code as always SMP safe, and I want to
> > remove the CONFIG_*_SMP conditionals. They make no sense for a bios.
>
> Interesting point of view. As long as we're allowed to make locking on
> pure uniprocessor architectures a no-op, I'm totally for it.

yeah, locks on up always succeed and there's no contention :-)

ron