Dear coreboot folks,
It’s great to see, that there a quite a few contributions – even the majority – from people paid to do coreboot work.
Especially Intel and Google seem to employ a lot of developers working on coreboot, and a lot of them push patches up for review. That’s great.
My impression is though, that a lot of these contributions have formal issues in the beginning. As the coding style and the commit message guide lines are well documented in our Wiki [1][2], and there are even scripts checking commits, the developers starting to work on coreboot just don’t seem to know about this.
How can this be improved?
Could the companies make sure, that there developers read those, and use the scripts?
Should this documentation be moved to the repository? A lot of the “guideline Wiki pages” are locked anyway. People knowing the Linux kernel, would expect that to also live in the source code repository?
Thanks,
Paul
[1] https://www.coreboot.org/Coding_Style [2] https://www.coreboot.org/Git#Commit_messages