Re: [coreboot] current dtc patch

[Carl-Daniel Hailfinger]

On 05.09.2008 22:22, Carl-Daniel Hailfinger wrote:
> On 04.09.2008 18:04, ron minnich wrote:
> > no ack in it, for your viewing pleasure.
> >
> > Tested on dbe62.
>
> Looks nice.
> Acked-by: Carl-Daniel Hailfinger

It exploded with the current dts of the AMD Serengeti, though, and
produced this statictree.c excerpt:
> struct device dev_ioport_2e = {
>         .path = {{.type=DEVICE_PATH_IOPORT,{.ioport={.iobase=0x2e}}},

One opening bracket too many.
>     .device_configuration = &ioport_2e,
>     .next = &dev_domain_0,
>     .links = 0,
>     .bus = &dev_domain_0.link[0],
>     .next = &dev_domain_0,
>     .dtsname = "ioport_2e",
>     .enabled = 1
>
> };

Regards,
Carl-Daniel