On Fri, 2010-06-04 at 12:29 -0600, Myles Watson wrote:
Signed-off-by: Marc Bertens mbertens@xs4all.nl
Acked-by: is the tag you want if you agree with the patch and want it to
be
committed. I'm hoping that means you tested it.
Ok, i mis understand you then, because i was not seeing any real changes. But i will test the patches.
I didn't mean for there to be any, but I wanted to make sure I didn't break it.
- I understood most of the changes, but why remove the register
settings for the keyboard and mouse?
Were they causing a problem?
The IP530 doesn't have a mouse or keyboard, they where not a problem, but i dont like any thing these that is not nessary.
Then should they be turned off? I agree that simpler is better.
- there's no reason we can' t use tabs when it gets committed, I
just
couldn't see the differences.
Did you have a preference here?
Regarding the tabs, i was just folling the coding rules, nothing more or less :-)
Sorry about that. It is an unofficial exception because the device trees get so deeply nested. I agree that we should make it official or use tabs.
I will send you an ack when i tested it.
Great. You could also test turning off the floppy and sign off an updated patch. I'll Ack and commit it.
Thanks, Myles