Re: [coreboot] [commit] r5319 - trunk/src/arch/i386/include/arch

[Stefan Reinauer]

On 3/30/10 12:15 AM, Myles Watson wrote:
> Modified: trunk/src/arch/i386/include/arch/pirq_routing.h
> ==============================================================================
> --- trunk/src/arch/i386/include/arch/pirq_routing.h     Mon Mar 29
> 23:56:26 2010        (r5318)
> +++ trunk/src/arch/i386/include/arch/pirq_routing.h     Tue Mar 30
> 00:05:26 2010        (r5319)
> @@ -18,9 +18,8 @@
>
>  #if defined(CONFIG_IRQ_SLOT_COUNT)
>  #define IRQ_SLOTS_COUNT CONFIG_IRQ_SLOT_COUNT
> -#elif (__GNUC__ < 3)
> -#define IRQ_SLOTS_COUNT 1
>  #else
> +#warning "No IRQ_SLOT_COUNT in Kconfig."
>  #define IRQ_SLOTS_COUNT
>  #endif
>
> I think we should get rid of IRQ_SLOTS_COUNT and move the error into
> Kconfig.  The added warning is very similar to one in pirq_routing.c

I like that much better... do you have a patch in mind?