Re: [LinuxBIOS] r2664 - in trunk/LinuxBIOSv2: src/mainboard/amd/norwich targets/amd/norwich

[Stefan Reinauer]

* [e-mail]  [070514 13:34]:
> Modified: trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c
>
> --- trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c	2007-05-11 19:23:57 UTC (rev 2663)
> +++ trunk/LinuxBIOSv2/src/mainboard/amd/norwich/failover.c	2007-05-14 11:33:41 UTC (rev 2664)
> @@ -8,24 +8,5 @@
>
> static unsigned long main(unsigned long bist)
>  {
> -#if 0
> /* This is the primary cpu how should I boot? */
> if (do_normal_boot()) {
> goto normal_image;
> } else {
> goto fallback_image;
> }
>  normal_image:
> asm volatile ("jmp __normal_image":	/* outputs */
>       :"a" (bist)	/* inputs */
>       :		/* clobbers */
>    );
>  cpu_reset:
> asm volatile ("jmp __cpu_reset":	/* outputs */
>       :"a" (bist)	/* inputs */
>       :		/* clobbers */
>    );
>  fallback_image:
>
> -#endif
>    return bist;
>  }

Please rather fix then delete code like this.

By deleting it you just manifest that nobody will ever fix this, as
nobody will check the history.

Stefan