Re: [coreboot] [PATCH v2] AMD DBM690T IRQ cleanup

[Carl-Daniel Hailfinger]

On 02.10.2008 02:41, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
> > New attempt with more cleanups and hopefully correct conversion:
>
> Still not. I think this will be faster by hand.

Ah, and I did a search/replace for the decimal/hex conversion to avoid
typos, so the typo struck me in thesearch/replace. My bad.
> > +#define IO_LOCAL_INT(type, intr, apicid, pin) \
> > +#define ISA_INT(intr, pin) \
>
> ..maybe ISA_INT should also take apicid?

I'll try to find out whether there is any board in v2 where ISA_INT
would need two different apicids. This is on my global cleanup list anyway.
> > /* sata */
> > smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW,
> > 	 0, 18 << 2 | 0, apicid_sb600, 22);
> > PCI_INT(0x0, 0x13, 0x0, 0x16);
>
> Problem here: 18 != 0x13
> > smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW,
> > 	 bus_rs690[2], 0x0 << 2 | 0, apicid_sb600, 18);
>
> ..
> > smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW,
> > 	 bus_rs690[6], 0x0 << 2 | 0, apicid_sb600, 18);
> > PCI_INT(bus_rs690[2], 0x0, 0x0, 0x13);
> > PCI_INT(bus_rs690[6], 0x0, 0x0, 0x13);
>
> Again: 18 != 0x13
>
> Fine otherwise. Fix the above and commit please.
>
> Acked-by: Peter Stuge

Thanks, r3628.

Regards,
Carl-Daniel