Re: [coreboot] [PATCH 4/6] Support for the Intel 945 northbridge

[Stefan Reinauer]

On 07.11.2008, at 19:09, "Myles Watson"  wrote:
> > > >
> >
> > Ok, trying to address the issues:
>
> Thanks.  It makes it more motivating to do future reviews.

Sorry I didn't reply earlier. Your input is much appreciated. Don't be  
demoticated by the delay. Stuff like this won't be lost.
> > > //Consistency with \r\n ...
> > > > printk_debug("ok\r\n");
> > > >
> > > > +}
> > > >
> > > > +static void i945_setup_egress_port(void)
> > > > +{
> > > > u32 reg32;
> > > > u32 timeout;
> > >
> > > //and just \n
> >
> > Which one is the right one to use these days?
>
> I think the consensus was just \n.  That's what v3 uses all the way  
> through.

In v3 we use the same printk all over the place, while in v2 we have a  
mess... I think print_debug wanted \r while printk_debug does the  
right thing and attaches it automatically. So I need to fix \r\n to.  
\n in a lot of places.

Thanks,
Stefan