Re: [LinuxBIOS] question on lx raminit.c

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> On 20.10.2007 02:44, ron minnich wrote:
> > I offer the following diff and a question: can the use of && in these
> > if expressions be wrong?
> >
> > Currently it is:
> > if ((MIN_MOD_BANKS > spd_byte) && (spd_byte > MAX_MOD_BANKS))
>
> You want || because either condition should cause the error message. The
> current statement will never be true because
>
> (MIN_MOD_BANKS > MAX_MOD_BANKS) is never true.
>
> Patch looks fine to me.
> Acked-by: Carl-Daniel Hailfinger
>
> Carl-Daniel

Indeed,  I didn't test it with an non-supported dimm....
Marc