On 30.12.2007 13:08, a a wrote:
can somebody please ack this ?
Signed-off-by: Reinder E.N. de Haan lb_reha@mveas.com
This patch fixes non working erasing of Pm49fl002/4 The erasing part of writing did work because it uses erase_block_jedec and not erase_chip_jedec datasheets says: "Chip erase is available in A/A Mux Mode only."
this patch needs the patch from: http://www.linuxbios.org/pipermail/linuxbios/2007-November/027287.html
You could ack the old lockbits patch if it works for you. IMHO the lockbits patch is not really obvious and would benefit from some small readability (variable naming) improvements, but I don't see anything obviously wrong with it, either. If you ack, I'll commit.
Your patch looks mostly fine, but could you try to limit line length to 80 chars?
Regards, Carl-Daniel