Re: [coreboot] [PATCH] v2: Enable CBFS and HIGH_TABLES for MSI MS-6178

[Myles Watson]

> The trouble I was having earlier with CBFS seems to come from removing
> the "normal" image (to get more space in the ROM).

Strange.  I thought that was fixed.
> The attached patch works fine though.

The HIGH_TABLES failed with:

No matching ram area found for range:
    [0x00000000000f0000, 0x0000000000100000)
  Ram areas
    [0x0000000000000000, 0x0000000000001000) Reserved
    [0x0000000000001000, 0x00000000000a0000) RAM
    [0x0000000000100000, 0x000000000fff0000) RAM
    [0x000000000fff0000, 0x0000000010000000) Reserved
  SELFBOOT RETURNED!
  Boot failed.

This looks like a separate issue from HIGH_TABLES support.  It looks like
the payload wasn't finding RAM to live in.  Did you try SeaBIOS as a payload
without HIGH_TABLES support?

===================================================================
--- src/northbridge/intel/i82810/northbridge.c	(Revision 4363)
+++ src/northbridge/intel/i82810/northbridge.c	(Arbeitskopie)
@@ -170,7 +170,7 @@
    	/* Report the memory regions. */
    	idx = 10;
    	ram_resource(dev, idx++, 0, 640);
-		ram_resource(dev, idx++, 1024, tolmk - 1024);
+		ram_resource(dev, idx++, 768, tolmk - 768);

I think it would be nice if there were some easy way to see that 768K =
0xC0000 here, but I'm not sure of the best way to express that.  Maybe just
a comment.

Acked-by: Myles Watson

Thanks,
Myles