Re: [coreboot] [PATCH] Add support for Asus M4A785-M, with build instructions

[Myles Watson]

> > From your mainboard's Kconfig:
> >
> > +config DIMM_SUPPORT
> > hex
> > default 0x0004
> > depends on CPU_AMD_SOCKET_AM3
> >
> > This really worries me.  You shouldn't need to change the type of memory
> > on
> > the Socket.  I looked at your board online, and they suggest that your
> > board
> > supports socket AM2, AM2+, and AM3.  That seems like it breaks our model.
> >  I
> > thought AM2 was DDR2 and AM3 was DDR3.
>
> Sorry to break your design, but that was what I had to do to get the RAM
> working.

I wasn't offended.  I just want to improve the design if it's broken.
> I can confirm that I am using DDR2 memory and the CPU is this:
>
> http://products.amd.com/en-na/DesktopCPUDetail.aspx?id=615

Thanks.
> > In general, the fewer changes the better!
>
> I agree. The patches could be smaller and neater.
>
> However, I cannot hold on to this board for arbitrarily long, since I should
> put it to production use now that Coreboot is working.  I will see what I
> can do to reduce these patches further, if I just find a suitable slot of
> time.

I appreciate the work that you've done.  I've attached patches that
I've reduced a little more.  Would you test/review them?  If they
work, I'll commit them.

Signed-off-by: Myles Watson

Thanks,
Myles