As DBE61 support now runs ram_check for non-debug purposes and has expected failures on DBE61A, downgrade the per-address looped fail notification printk and other messages from BIOS_ERR to BIOS_DEBUG. Document that if something is wanted to be reported in non-debug loglevels, one should do so in the caller based on the return value. Tweak a debug string in ram_verify to be more descriptive.
Signed-off-by: Mart Raudsepp mart.raudsepp@artecdesign.ee --- lib/ramtest.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/ramtest.c b/lib/ramtest.c index 02a4bdb..8d5c419 100644 --- a/lib/ramtest.c +++ b/lib/ramtest.c @@ -97,11 +97,11 @@ static int ram_verify(unsigned long start, unsigned long stop) value = ram_read_phys(addr); if (value != addr) { /* Display address with error. */ - printk(BIOS_ERR, "Fail @%lx Read value=%lx\n", + printk(BIOS_DEBUG, "Fail @%lx Read value=%lx\n", addr, value); /* Abort after 256 verify errors. */ if (++i > 256) { - printk(BIOS_ERR, "Aborting.\n"); + printk(BIOS_DEBUG, "256 errors seen, aborting.\n"); break; } } @@ -111,7 +111,7 @@ static int ram_verify(unsigned long start, unsigned long stop) printk(BIOS_DEBUG, "%lx\r", addr);
/* Print whether or not the verify failed. */ - printk(BIOS_DEBUG, "\nDRAM range %sverified.", i ? "_NOT_ " : ""); + printk(BIOS_DEBUG, "\nDRAM range %sverified.\n", i ? "_NOT_ " : ""); return i; }
@@ -121,6 +121,8 @@ static int ram_verify(unsigned long start, unsigned long stop) * * This is much more of a "Is my DRAM properly configured?" test than * a "Is my DRAM faulty?" test, though. + * If you want to show a message of the result in non-debug loglevels, be sure + * to do so yourself based on the return value. * * @param start The beginning of the RAM area. * @param stop The end of the RAM area.