On 13.11.2008 03:56, Mart Raudsepp wrote:
On N, 2008-11-13 at 01:51 +0100, Carl-Daniel Hailfinger wrote:
On 13.11.2008 01:18, Mart Raudsepp wrote:
artecgroup/dbe61: Use dbe61c specific variables and macros instead of generic ones
This is in preparation of dbe61a handling addition.
Uses DIMM_DBE61C and DIMM_EMPTY instead of generic DIMM0/DIMM1, and spd_table_dbe61c instead of spd_table.
I somehow dislike using 0xA2 for DIMM_EMPTY. Sorry.
Note that 0xA2 is used by all other boards that have soldered on memory as one DIMM. It's just named perhaps less intuitively DIMM1. In case of DBE61 what really makes these values perhaps not ideal, is the addition of a third one that is an OR relationship with the first.
Hm yes. Could you convert all other boards with soldered DIMMS to the DIMM_EMPTY scheme as well? That change would be Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
What random numbers between 0x00 and 0xFF would you suggest for all the three then? :)
You gave a perfectly valid reason to keep it as is. Go for it. If we ever want to move DIMM_EMPTY to 0x0 or something else, we can do so in a separate patch.
Regards, Carl-Daniel