Re: [coreboot] New patch to review for coreboot: deb6f0f Add ASUS M5A88-V mainboard support

[QingPei Wang]

hi Paul,
i tested by my opensuse 11.2 without X windows. the patch is applicable to
the former two patches which i sent before.
And it does not depend on any other patches by AMD at this moment.
And i am trying to get familiar with gerrit at this moment. I just learned
how to submit the patches, still does not know
how to use "git format-patch" things.

The attachment is a simple boot log with the board. I will cost more time to
make this better.

Best wishes
Wang Qing Pei
Phone: 86+018930528086

On Tue, Sep 6, 2011 at 10:28 PM, Paul Menzel <
[e-mail]> wrote:
> Dear QingPei,
>
> Am Dienstag, den 06.09.2011, 15:12 +0200 schrieb QingPei Wang:
> > commit deb6f0f225bddd2fa786f94689555a21add12d13
> > Author: QingPei Wang 
> > Date:   Tue Sep 6 21:09:40 2011 +0800
> > Add ASUS M5A88-V mainboard support
> >
> > it's a AMD 880+800 mainboard. I port the code
> > based on the AMD reference code.
>
> nice job! Thank you for doing that.
>
> Could you please add to the commit message what you have tested, i. e.
> what does work and what does not work? Additionally what operating
> system did you test? Is that patch applicable to master with your other
> two(?) patches or does it depend on other patches send by AMD not yet in
> master?
> > Change-Id: I9725ccdbb25365c4007621318efee80b131fec29
> > Signed-off-by: QingPei Wang <[e-mail]>
> >
> > src/mainboard/asus/Kconfig                  |    3 +
> >  src/mainboard/asus/m5a88-v/Kconfig          |  107 ++
> >  src/mainboard/asus/m5a88-v/Makefile.inc     |   20 +
> >  src/mainboard/asus/m5a88-v/acpi/cpstate.asl |   75 ++
> >  src/mainboard/asus/m5a88-v/acpi/ide.asl     |  244 ++++
> >  src/mainboard/asus/m5a88-v/acpi/routing.asl |  398 ++++++
> >  src/mainboard/asus/m5a88-v/acpi/sata.asl    |  149 +++
> >  src/mainboard/asus/m5a88-v/acpi/usb.asl     |  161 +++
> >  src/mainboard/asus/m5a88-v/acpi_tables.c    |  274 ++++
> >  src/mainboard/asus/m5a88-v/chip.h           |   22 +
> >  src/mainboard/asus/m5a88-v/cmos.layout      |   98 ++
> >  src/mainboard/asus/m5a88-v/devicetree.cb    |  124 ++
> >  src/mainboard/asus/m5a88-v/dsdt.asl         | 1824
>
> +++++++++++++++++++++++++++
> > src/mainboard/asus/m5a88-v/fadt.c           |  201 +++
> >  src/mainboard/asus/m5a88-v/get_bus_conf.c   |  147 +++
> >  src/mainboard/asus/m5a88-v/irq_tables.c     |  111 ++
> >  src/mainboard/asus/m5a88-v/mainboard.c      |  150 +++
> >  src/mainboard/asus/m5a88-v/mb_sysconf.h     |   43 +
> >  src/mainboard/asus/m5a88-v/mptable.c        |  160 +++
> >  src/mainboard/asus/m5a88-v/pmio.c           |   53 +
> >  src/mainboard/asus/m5a88-v/pmio.h           |   33 +
> >  src/mainboard/asus/m5a88-v/reset.c          |   63 +
> >  src/mainboard/asus/m5a88-v/resourcemap.c    |  278 ++++
> >  src/mainboard/asus/m5a88-v/romstage.c       |  280 ++++
> >  24 files changed, 5018 insertions(+), 0 deletions(-)
>
> […]
>
> The diff is pretty big. I guess a lot of files have been copied over?
> Can Gerrit send smaller diffs by using `git format-patch -M -C` (?) or
> so?
>
> Thanks,
>
> Paul