Am Donnerstag, 16. Dezember 2010, um 06:09:50 schrieb Stefan Reinauer:
$(obj)/coreboot.pre: $(obj)/coreboot.bootblock $(CBFSTOOL)
rm -f $@
- $(CBFSTOOL) $@ create $(CONFIG_COREBOOT_ROMSIZE_KB)K
$(obj)/coreboot.bootblock
- cp $(obj)/coreboot.pre1 $@
This looks odd. Is it needed?
Yes: The generic Makefile.inc code in arch/x86 creates a coreboot.pre1 with the cbfs-files-y data. Makefile.bootblock.inc then adds the romstage and calls the result coreboot.pre. Makefile.bigbootblock.inc has nothing to do in that intermediate step from .pre1 to .pre, but to keep the dependency graph identical, we need to copy the data around.
- The coreboot.pre1 rule is now generic code. - The coreboot.pre rule is bootblock/bigbootblock code. - The further processing (coreboot.pre -> coreboot.rom) is generic code again.
This used to be: - The coreboot.pre rule is bootblock/bigbootblock code (and the bootblock code uses .pre1 as intermediate step) - The further processing (coreboot.pre -> coreboot.rom) is generic code.
Patrick