Quoting Uwe Hermann uwe@hermann-uwe.de:
On Thu, Oct 18, 2007 at 06:19:58PM -0600, Marc Jones wrote:
here's a first patch (in a row of a bunch of other, similar planned patches) which reduces the amount of crappy, duplicated mainboard code in the repository. (it also adds support for a new target, the Advantech PCM-5820, btw.) This common code supports three different GX1-boards, more will follow. We have at least 7 of them in the repo right now (and I'll add more), duplicating the same crap in each mainboard/* directory again and again is definately not what we want to do.
Uwe, Good stuff! If you are interested, it would be good to do this for the LX/5536 platforms too. What do you think?
Yes, definately. IMO we can do this for pretty much all chipsets, e.g.
src/common/gx1-base src/common/lx-base src/common/i440bx-base src/common/ck804-base src/common/mcp55-base etc. etc.
My next patch will be for the Intel 440BX though, as I can personally test those boards.
Alot of the intel chipsets have common functions. Maybe some other ones can be included? I think this is a good Idea. Eliminating duplicated code and adding it globaly can simplify things when adding support for a new chip.
Thanks - Joe