RE: [LinuxBIOS] Latest commit - clarification

[Lu, Yinghai]

San,

Please check the patch for CAR

1.	add cpu_init_detectedx, it is passed from cache_as_ram.inc and
to amd64_main... 
2.	add init_cpus for CAR ---more readable
3.	post_cache_as_ram   ---> make cache_as_ram_auto.c shorter....
4.	renable get_apicid_base, in case some one still want BSP apid id
=0 but other cpu is lifted.

YH

________________________________

From: [e-mail]
[mailto:[e-mail]] On Behalf Of San Mehat
Sent: Wednesday, October 26, 2005 9:55 AM
To: Eric W. Biederman
Cc: LinuxBIOS
Subject: Re: [LinuxBIOS] Latest commit - clarification

On 10/25/05, Eric W. Biederman  wrote:

killing get_apicid_base looks like a bug.
But as far as I can tell everything that is gone is now unnecessary.

Okay... so what replace start_other_cores()?.. In CAR mode, do I make a
call to 'do_k8_init_and_stop_secondaries()'?
That code itself wont build due to the following in
'k8_init_and_stop_secondaries()':
  if (init_detected) {
                asm volatile ("jmp __cpu_reset");
        }

because in CAR configs, arch/i386/lib/cpu_reset.inc is not included. On
this particular issue, I'm happy to wait for YH's fixes.

I just think if we're going to deprecate a core call like that, there
should be some documentation on *why* it was removed, as well as some
indication as to where the behavior got 'moved' to.

It just makes things a lot easier for thoes of us that are either
ramping up, or trying to maintain things..

Thanks Eric ;)

-san

PS: I'm still going to get you drunk and shave your beard.