Re: [coreboot] [PATCH] Move cmos.default handling to bootblock

[Georgi, Patrick]

Am Freitag, den 18.02.2011, 03:55 +0100 schrieb Peter Stuge:
> Patrick Georgi wrote:
> > The cmos.default code wasn't actually used so far, due to an oversight
> > when forward-porting this feature from an old branch.
> > Extend walkcbfs' use by factoring out the stage handling into C code.
> > New sanitize_cmos() function that looks if CMOS data is invalid and
> > cmos.default exists and if so overwrites CMOS with cmos.default data.
> > Use sanitize_cmos() in both bootblock implementations.
> > Drop the need to reboot after writing CMOS: CMOS wasn't used so far,
> > so we can go on without a reboot.
> > Remove the restriction that cmos.default only works on CAR boards.
> > Always build in cmos.default support on boards that USE_OPTION_TABLE.
>
> Is there a Kconfig option for enabling the NVRAM write? I would like
> that very much. I'd also like it to be off by default.

HAVE_CMOS_DEFAULT. Without this, cmos.default isn't put into CBFS (by
default), and without that file, no write happens.
> Maybe we should consider some coreboot "profiles" for Kconfig, that
> would autoselect options, which could be manually overridden by
> experts?

"profiles"? We have those: mainboard defaults.

Patrick